Created by: jonnii
The intention of this change is to allow someone to supply their own OkHttpClient to the ApiClient in the event that they don't want to pay the price for creating a new client even when if they're going to setHttpClient.
A specific example of this is if you have multiple ApiClients (e.g. imagine a user service and an avatar service) which have different API contracts but could share the same DNS/caching/resiliency settings etc...
I appreciate that this could be solved with a custom template but this felt useful enough to contribute.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.