Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !6425

[Typescript] Support http bearer authentication with token provider

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bodograumann/ts-bearer-auth into typescript-refactor-master May 25, 2020
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 24

Created by: bodograumann

Previously I defined my own SecurityAuthentication class. This PR adds support for bearer token authentication directly to the typescript generator. The configuration requires a (possibly asynchronous) token provider class. This is so that the token can be refreshed if necessary. Also the token provider can later be injected with inversifyjs.

Would it be useful, to also use credential providers in the other security types? Maybe a more generic solution could be used? In our use case the bearer token changes frequently, but I'm not sure what the common api token or basic auth use cases need.

I also updated typescript to 3.9 which hopefully avoids some issues with the ancient version we where using before. Some commits are cherry-picked from typescript-refactor-master-oaiv3 to make the tests work, but once #6416 is merged, I can remove them again. Furthermore I added a fix for http basic auth.

Cf. #802 (closed) CC @TiFu

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bodograumann/ts-bearer-auth