Skip to content
GitLab

[java][jersey2] Add support for discriminator, fix nullable typo and nullable deserialization

Merged Administrator requested to merge github/fork/CiscoM31/jersey2-discriminator into jersey2-improvement

Created by: sebastien-rosset

  1. Fix nullable typo, the mustache template had isNulalble
  2. Add support for discriminator in jersey2 library.
  3. The deserialization code was incorrectly accepting null as input data for non-nullable anyOf/oneOf schemas. If the input data is null and the anyOf/oneOf does not accept null (either because nullable: true or type: 'null' is a child anyOf/oneOf, then a deserialization exception should be raised. Note: it's likely this problem exists for other schema types too.
  4. When there is more than one level of anyOf/oneOf, the deserialization was previously failing. This is shown with the existing sample OAS 3.0 doc that works with the python and go clients.

Newly discovered issues:

  1. The existing jersey2 implementation of oneOf/anyOf is incomplete. It is supposed to validate the input data against the JSON schema, but it does not validate any constraint (enum, min, max...)
  2. Other issues listed with TODO comments in the Unit test file.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.