Skip to content
GitLab

[Jersey2] Fix code generation of 'registerDiscriminator' method for large models

Merged Administrator requested to merge github/fork/CiscoM31/jersey2-method-too-big into jersey2-improvement

Created by: sebastien-rosset

  1. For a large model, the generated registerDiscriminators method was too big. Now each model class is registering itself with the registry.
  2. Improve code comments.
  3. Minor refactor.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.