Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !6541

[php-slim4] Mark generated tests as incomplete

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ybelenko/slim4_incomplete_tests into master Jun 04, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 59

Created by: ybelenko

I've found markTestIncomplete method in PHPUnit. It perfectly fits our autogeneration flow. Ref: PHPUnit 7.0 Manual - 7. Incomplete and Skipped Tests

Result of tests:

$ composer test
> phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII.II.II.IIIIIIIIIIII.II.I  63 / 520 ( 12%)
I.II.II.III.IIII.II.II.IIII.II.IIIII.IIIIIII.II.IIII.III.II.II. 126 / 520 ( 24%)
II.IIII.III.I.IIIIII.III.II.IIIIIIIIIIIIIII.III.IIIII.IIII.III. 189 / 520 ( 36%)
II.II.IIIII.II.IIIIIII.IIII.I.IIIIIII.III.II.III.IIIIII.IIIIIII 252 / 520 ( 48%)
.IIIIIIIII.IIIIIIIIIIIIIIIIIIIIIIIIIIIIII...................... 315 / 520 ( 60%)
............................................................... 378 / 520 ( 72%)
............................................................... 441 / 520 ( 84%)
............................................................... 504 / 520 ( 96%)
................                                                520 / 520 (100%)

Time: 2.88 seconds, Memory: 18.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 520, Assertions: 8004, Incomplete: 246.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ybelenko/slim4_incomplete_tests