Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !6580

Remove the json dependency

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jfeltesse-mdsol/ruby/rm_json_dep into master Jun 08, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: jfeltesse-mdsol

JSON has been included in ruby since 1.9:

$ irb -f
irb(main):001:0> RUBY_VERSION
# => "1.9.3"
irb(main):002:0> require "json"
# => true
irb(main):003:0> JSON
# => JSON

Forcing everyone to use a recent version like 2.1+ is a good thing but sometimes it may be detrimental: some older apps may still be stuck on 1.x for some reason and currently they wouldn't be able to use generated clients because of the 2.1+ requirement. Unless there's a specific reason to use 2.1+ in the clients, listing (or not) json as a dependency should be up to the user of the generated clients.

For example, rails dropped the explicit dependency a long time ago (PR).

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@cliffano @zlx @autopp @wing328

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jfeltesse-mdsol/ruby/rm_json_dep