Created by: rfecher
This is actually referenced here and it addresses issue #5381 (closed) nicely.
I'm willing to do the legwork to get the PR in, however I'm not actually the author, and I'd think to maintain the license agreement we'd need consent from @mmalygin
PR checklist
- [ X ] Read the contribution guidelines.
- [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
this step is unclear to me, I run a bunch of the scripts and it seems many seemingly unrelated files changed like all the FakeApi.java files changed put("http", EncodingUtils.encodeCollection(value, "ssv")); to put("http", EncodingUtils.encodeCollection(value, "space")); which seems completely outside of the scope of this bugfix
-
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). - [ X ] File the PR against the correct branch:
master,4.3.x,5.0.x. Default:master. further guidance would be appreciated here -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.