Skip to content
GitLab

[php-symfony] Set required PHP version to ^7.2.5

Closed Administrator requested to merge github/fork/ybelenko/6522_symfony_server into master

Created by: ybelenko

Update PHP client package and PHPUnit to meet PHP 7.2 version. Related issue #6522 (closed)

Test results from samples/server/petstore/php-symfony/SymfonyBundle-php:

$ vendor/bin/phpunit
PHPUnit 8.5.5 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 9:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Test results may not be as expected.


[info] Matched route "open_api_server_pet_addpet".

(...)

53) OpenAPI\Server\Model\UserTest::testPropertyUserStatus
This test did not perform any assertions

/Users/ybelenko/Sites/openapi-generator/samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/Model/UserTest.php:135

OK, but incomplete, skipped, or risky tests!
Tests: 62, Assertions: 9, Risky: 53.

and with PHPUnit 9:

$ vendor/bin/phpunit
PHPUnit 9.2.2 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 9:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Test results may not be as expected.


[info] Matched route "open_api_server_pet_addpet".

(...)

53) OpenAPI\Server\Model\UserTest::testPropertyUserStatus
This test did not perform any assertions

/Users/ybelenko/Sites/openapi-generator/samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/Model/UserTest.php:135

OK, but incomplete, skipped, or risky tests!
Tests: 62, Assertions: 9, Risky: 53.

This PR won't pass Travis CI, because root .travis.yml of this repo configured to PHP 7.1 https://github.com/OpenAPITools/openapi-generator/blob/ebcce674197b0bea1772d1a3074acf0c10650b60/.travis.yml#L88

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon cc @reznikartem as last Symfony contributor cc @FlaverSaver as person who asked for Symfony 5 support