Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !6753
An error occurred while fetching the assigned milestone of the selected merge_request.

[Rust][Client] Unify sync/async client structure

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/bcourtine/unify-sync-async-structure into master 5 years ago
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 20

Created by: bcourtine

Unify structure:

  • Remove xxxApiClient structures and traits.
  • Configuration is now passed as function argument (instead of being part of the client struct).

This evolution makes much easier the sync/async switch since structure and signatures are now much closer.

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @wing328

Also cc @HenningHolmDE @seunlanlege since you are currently the main rust generator users.

Approval is optional

Merge details

  • 2 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity


  • William Cheng added Breaking change (without fallback) Client: Rust labels 5 years ago

    added Breaking change (without fallback) Client: Rust labels

  • William Cheng changed milestone to %5.0.0 5 years ago

    changed milestone to %5.0.0

  • William Cheng closed 5 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/bcourtine/unify-sync-async-structure

Menu

Explore Projects Groups Snippets