Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !6938

[Java] Treat classes from java.lang as reserved words

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/joschi/java-generator-java-lang-classes into master Jul 14, 2020
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 4

Created by: joschi

Classes in the package java.lang are available without explicitly importing them:

A compilation unit automatically has access to all types declared in its package and also automatically imports all of the public types declared in the predefined package java.lang.

Source: https://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html

This leads to naming collisions in the generated code if there is a schema named like a class in java.lang.

For example a schema named override would clash with java.lang.Override, an annotation used in virtually every template for the Java generators.

As the least intrusive method (with regards to existing templates), we handle classes from java.lang as reserved words, so that they will be renamed accordingly.

PR checklist

  • Read the contribution guidelines.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda @wing328

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/joschi/java-generator-java-lang-classes