Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !7073
An error occurred while fetching the assigned milestone of the selected merge_request.

[Protobuf] Generate enum fields

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/k0ral/master into master 4 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: k0ral

An example will best illustrate the point of this pull-request. Take the following OpenAPI definition:

swagger: "2.0"
info:
  title: MyModel
  version: "1.0"
paths: {}

definitions:
  MyModel:
    type: object
    properties:
      color:
        type: string
        enum:
          - RED
          - BLUE
          - GREEN

Without this pull-request, the generated protobuf file looks like:

message MyModel {
  enum color {
    RED = 0;
    BLUE = 1;
    GREEN = 2;
  }
}

With this pull-request, the generated protobuf file looks like:

message MyModel {
  enum ColorEnum {
    RED = 0;
    BLUE = 1;
    GREEN = 2;
  }

 ColorEnum color = 1;
}

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Compare
  • master (base)

and
  • latest version
    646b0ceb
    1 commit, 2 years ago

1 file
+ 3
- 1

    Preferences

    File browser
    Compare changes
modules/openapi-generator/src/main/resources/protobuf-schema/model.mustache
+ 3
- 1
  • View file @ 646b0ceb

  • Edit in single-file editor

  • Open in Web IDE


@@ -21,13 +21,15 @@ message {{classname}} {
{{#vendorExtensions.x-protobuf-type}}{{.}} {{/vendorExtensions.x-protobuf-type}}{{vendorExtensions.x-protobuf-data-type}} {{name}} = {{vendorExtensions.x-protobuf-index}}{{#vendorExtensions.x-protobuf-packed}} [packed=true]{{/vendorExtensions.x-protobuf-packed}};
{{/isEnum}}
{{#isEnum}}
enum {{name}} {
enum {{enumName}} {
{{#allowableValues}}
{{#enumVars}}
{{{name}}} = {{{protobuf-enum-index}}};
{{/enumVars}}
{{/allowableValues}}
}
{{enumName}} {{name}} = {{vendorExtensions.x-protobuf-index}};
{{/isEnum}}
{{/vars}}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/k0ral/master

Menu

Explore Projects Groups Snippets