From slack… generation via online is broken due to errors.
For example:
curl -X POST "https://api-latest-master.openapi-generator.tech/api/gen/clients/csharp" -H "Accept: */*" -H "Content-Type: application/json" -d "{ \"openAPIUrl\": \"https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/modules/openapi-generator/src/test/resources/2_0/petstore.yaml\"}"Results in an error:
{"timestamp":"2020-07-31T13:05:33.674Z","status":500,"error":"Internal Server Error","message":"Could not initialize class io.swagger.v3.parser.OpenAPIV3Parser","path":"/api/gen/clients/csharp"}The online project was pulling in Jackson 2.9 deps which are not all ABI compatible with the 2.10 version we pull in with the newer swagger-parser. guava and snakeyaml were also old and potentially causing issues.
I've updated springboot to 2.2.9.RELEASE and springfox to 3.0.0 to address the version conflicts. The springboot bump from 2.0 to 2.2 requires providing bean ForwardedHeaderFilter because newer SpringBoot does not enable X-Forwarded- support by default and the property-based native or framework configuration does not work for X-Forwarded-Host and X-Forwarded-Port as we use and test for.
Release Notes
- [online] Upgraded springboot to 2.2.9.RELEASE
- [online] Upgraded springfox to 3.0.0
cc @OpenAPITools/generator-core-team
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.