Created by: mattdowdell
The server example is broken because it tries to import use openssl::ssl::SslAcceptorBuilder; unconditionally when it won't be present on MacOS, Windows or iOS and then conditionally provides create causing compile errors on the aforementioned platforms which try to unconditionally import said function in main.rs.
To fix, we simply move the condition from the function to the import and all is happy again :)
To verify, generate the code from any spec, then attempt to use the server example on one of the problem platforms.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @frol @farcaller @richardwhiuk @paladinzh for review.