Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !7460

Fix stringifying of ~= in enums

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/aidanhs/aphs-fix-tilde-equals into master Sep 20, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: aidanhs

Fixes #4069 (closed)

The jira openapi spec includes "~=" as a value of an enum. This change ensures it gets stringified correctly.

You can see the problem by performing Rust codegen on https://developer.atlassian.com/cloud/jira/platform/swagger.v3.json:

$ java -jar openapi-generator-cli.jar generate -i $jiraspecpath -o jira-openapi -g rust --library reqwest --additional-properties packageName=jira-openapi
$ grep -A100 'pub enum Operator' jira-openapi/src/models/field_value_clause.rs
pub enum Operator {
    #[serde(rename = "=")]
    Equal,
    #[serde(rename = "!=")]
    Not_Equal,
    #[serde(rename = ">")]
    Greater_Than,
    #[serde(rename = "<")]
    Less_Than,
    #[serde(rename = ">=")]
    Greater_Than_Or_Equal_To,
    #[serde(rename = "<=")]
    Less_Than_Or_Equal_To,
    #[serde(rename = "in")]
    _In,
    #[serde(rename = "not in")]
    Not_in,
    #[serde(rename = "~")]
    Tilde,
    #[serde(rename = "~=")]
    ,
    #[serde(rename = "is")]
    Is,
    #[serde(rename = "is not")]
    Is_not,
}

The , on a line by itself is not valid Rust. With this change, that line becomes Tilde_Equal,

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/aidanhs/aphs-fix-tilde-equals