Created by: noordawod
This upgrades the Dart2 template to advertised best-practices by the Dart team and most importantly, use {{{ }}} to reference variables instead of {{ }} since the latter is for escaping values. It happened to me that occasionally the generated code would include " and &#XX; escape characters for some reason or another.
Few additions were added too:
- Allow users to decide whether an invalid enum throws an error or not -- handy since in the old case, when an API changes, outdated apps would crash.
- Added
growableto most calls that returns aList. Defaults to not allow growing a returned list. - Uses functional calls where possible (
=>). - Uses
finalvariables where possible. - Uses singleton instances for type transformers, lazily-instantiated.
- Added comments where needed.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12) @wing328