Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !7621

Adds missing items property to Java classes which store Schema info

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/spacether/adds_items_property into master Oct 07, 2020
  • Overview 0
  • Commits 6
  • Pipelines 0
  • Changes 8

Created by: spacether

Right now the master branch does not store the validations for array schema items for some classes This PR fixes that issue, validations in items are now accessible on the CodegenProperty items instance.

This PR

  • adds an items property to Java classes which store Schema info
    • the items property stores a CodegenProperty of the items of the current type Array schema
  • adds an isModel property so the generator can tell if the schema is a model or not
    • the intention is to have isModel be true for codegenModels or Schemas that ref codegenModels
    • that way generators will know to stop moving through schemas and use that one if it is a refed model If merged, this will be a partial fix for https://github.com/OpenAPITools/openapi-generator/issues/7613
    • it is up to the generators to set this property correctly

Tests have been added

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Core Team: @wing328 (2015/07) ❤️ @jimschubert (2016/05) ❤️ @cbornet (2016/05) @ackintosh (2018/02) ❤️ @jmini (2018/04) ❤️ @etherealjoy (2019/06) @spacether (2020/05)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/spacether/adds_items_property