Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !7631
An error occurred while fetching the assigned milestone of the selected merge_request.

Unifies naming for isArray in Schema class properties

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/spacether/fix/updates_array_map_propeties_for_consistency into master 4 years ago
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 212

Created by: spacether

We are using multiple properties that mean this schema is type array. The properties are:

  • isListContainer
  • isArrayModel

This PR updates our java classes that implement Schema to be consistent in out naming and getters and setters for this property. These classes have been updated:

  • CodegenProperty
  • CodegenModel
  • CodegenParameter
  • CodegenResponse

This PR:

  • changes isListContainer + isArrayModel to isArray
  • some locations were missed when changing to isMap, fixes those locations too
  • is a feature break out for https://github.com/OpenAPITools/openapi-generator/issues/7651

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Core Team Members @wing328 (2015/07) :heart:️ @jimschubert (2016/05) :heart:️ @cbornet (2016/05) @ackintosh (2018/02) :heart:️ @jmini (2018/04) :heart:️ @etherealjoy (2019/06) @spacether (2020/05)

Loading
Loading

Activity


  • Administrator changed title from Adds isArray for consistency to IJsonSchemaValidationProperties to Adds isArray and isMap to Schema classes 4 years ago

    changed title from Adds isArray for consistency to IJsonSchemaValidationProperties to Adds isArray and isMap to Schema classes

  • Administrator changed milestone to %5.0.0 4 years ago

    changed milestone to %5.0.0

  • Administrator added Breaking change (with fallback) label 4 years ago

    added Breaking change (with fallback) label

  • Administrator added Client: Java label 4 years ago

    added Client: Java label

  • Administrator changed title from Adds isArray and isMap to Schema classes to Adds isArray and isMap to Schema class properties 4 years ago

    changed title from Adds isArray and isMap to Schema classes to Adds isArray and isMap to Schema class properties

  • Administrator changed title from Adds isArray and isMap to Schema class properties to Adds unifies naming for isArray Schema class properties 4 years ago

    changed title from Adds isArray and isMap to Schema class properties to Adds unifies naming for isArray Schema class properties

  • Administrator changed title from Adds unifies naming for isArray Schema class properties to Unifies naming for isArray Schema class properties 4 years ago

    changed title from Adds unifies naming for isArray Schema class properties to Unifies naming for isArray Schema class properties

  • Administrator changed title from Unifies naming for isArray Schema class properties to Unifies naming for isArray in Schema class properties 4 years ago

    changed title from Unifies naming for isArray Schema class properties to Unifies naming for isArray in Schema class properties

  • Administrator mentioned in merge request !7640 (merged) 4 years ago

    mentioned in merge request !7640 (merged)

  • Administrator added Breaking change (without fallback) label and removed Breaking change (with fallback) Client: Java labels 4 years ago

    added Breaking change (without fallback) label and removed Breaking change (with fallback) Client: Java labels

  • Administrator closed 4 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Nikita Lutsenko
Administrator
Reference:
Source branch: github/fork/spacether/fix/updates_array_map_propeties_for_consistency

Menu

Explore Projects Groups Snippets