Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !7840

[rust-server] Add support for bearer token authentication

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mattdowdell/rust-server/bearerAuthSupport into master Oct 29, 2020
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 27

Created by: mattdowdell

As far as I can tell, the bulk of the work to support bearer tokens was already implemented to support OAuth, but never explicitly turned on. This was unexpectedly simple, so I susect I may have missed something.

Changes:

  • Added bearer token to the security features for rust server.
  • Supplemented the basic auth condition in the context template to handled basic auth and bearer token separately.
  • Repurpose an exising sample to confirm the code generation works as expected.

The new sample builds without problems, so the only possibly issue is that the underlying swagger crate didn't implement this. However, there's already bearer support in the client and it's also used in the OAuth support in the server, so I don't see why it wouldn't work.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @frol @farcaller @richardwhiuk @paladinzh

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mattdowdell/rust-server/bearerAuthSupport