Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !7877

[Dart2] Fix compile errors for required enums without default value.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gilbsgilbs/fix-dart-enum-default-value into master Nov 04, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: gilbsgilbs

Before:

  schemas:
    Order:
      type: object
      required: ["status"]
      properties:
        status:
          type: string
          enum:
            - placed
            - approved
            - delivered

Would produce the following Dart code which would fail to compile (because of a missing required parameter):

OrderEnum order = OrderEnum._();

This PR skips the enum initialization when no default value is provided.

Also, when a minimum value was specified for a property, I think there was a comment expected to display but wasn't (because it was in a wrong section). If fixed the comment value and put it in the proper section so that it shows.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language. @ircecho @swipesight @jaumard @athornz @amondnet
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gilbsgilbs/fix-dart-enum-default-value