- fix wrong escaped built_value serializer names
- prevent enum name collisions in inlined enums by prefixing the private built_value instances with the enum class name. This prevents clashes when multiple inline enums contain the same value - for example
EnumTest. No breaking changes here as all the changed fields/references are private and automatically re-generated with built_value.
There is still a lot wrong with enums but this is a small step.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.