Created by: Grohden
Details
I've made some fixes for the dart templates, @kuhnroyal and I had some discussion on #8179.
My changes were necessary to be able to compile my personal project and also the fake petstore generated clients.
Not all changes were made to fix compile errors: I've mistakenly enabled the implicit-casts:false on the generated client and then fixed the resulting analyzer errors..
- if fixing casts 'issues' and supporting that flag is not desired I can revert my cast changes.
- if fixing casts 'issues' and supporting that flag is desired we could enable the strong mode like @kuhnroyal did in #8231
From the changelist listed in #8179 I've fixed:
-
De-serialization of maps of maps e.g. Map<String, Map<String, String>>
(I've only fixed the compilation error, not sure if it will work properly on runtime)
Maybe I've fixed other issues.. but I'm not sure, would be glad if someone test it and confirm exactly what is still broken
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kuhnroyal could you comment on the casts you said that were uneeded?
@swipesight @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob