Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !8355

[dart][dart-dio] Add missing imports for container parameters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter Leibiger requested to merge github/fork/kuhnroyal/dart-dio/fix-collection-parameters into master 4 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

This adds missing imports for operations that have container type parameters. Also remove redundant needToImport check.

Fixes https://github.com/OpenAPITools/openapi-generator/issues/8273

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

Compare
  • master (base)

and
  • latest version
    20330da7
    1 commit, 2 years ago

2 files
+ 13
- 1

    Preferences

    File browser
    Compare changes
modules/…/…/…/…‎/…/…/…/languages‎
DartClientC‎odegen.java‎ +12 -0
DartDioClien‎tCodegen.java‎ +1 -1
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartClientCodegen.java
+ 12
- 0
  • View file @ 20330da7

  • Edit in single-file editor

  • Open in Web IDE


@@ -558,6 +558,18 @@ public class DartClientCodegen extends DefaultCodegen {
}
}
}
for (CodegenParameter p : op.allParams) {
if (p.isContainer) {
final String type = p.isArray ? "array" : "map";
if (typeMapping().containsKey(type)) {
final String value = typeMapping().get(type);
// Also add container imports for parameters.
if (needToImport(value)) {
op.imports.add(value);
}
}
}
}
return op;
}
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartDioClientCodegen.java
+ 1
- 1
  • View file @ 20330da7

  • Edit in single-file editor

  • Open in Web IDE


@@ -327,7 +327,7 @@ public class DartDioClientCodegen extends DartClientCodegen {
Set<String> imports = new HashSet<>();
for (String item : op.imports) {
if (needToImport(item)) {
if (importMapping().containsKey(item) && needToImport(item)) {
if (importMapping().containsKey(item)) {
fullImports.add(importMapping().get(item));
} else {
imports.add(underscore(item));
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: Dart Issue: Bug
2
Client: Dart Issue: Bug
    Assign labels
  • Manage project labels

Milestone
5.0.1
5.0.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Peter Leibiger
Reference: OpenAPITools/openapi-generator!8355
Source branch: github/fork/kuhnroyal/dart-dio/fix-collection-parameters

Menu

Explore Projects Groups Snippets