Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !8402

[Nim] bugfix for the case when path contains multiple parameters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/darklynx/bugfix/nim-client_path-multi-params into master Jan 10, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: darklynx

If REST end-point has a path with multiple parameters current api.mustache generates a broken Nim-code by repeating path string multiple times, for example:

proc getCompanyUser*(httpClient: HttpClient, companyId: string, userId: string): (Option[User], Response) =
  ## Get user of a company

  let response = httpClient.get(basepath & fmt"/companies/{companyId}/users/{userId}"fmt"/companies/{companyId}/users/{userId}")
  constructResult[User](response)

after this fix is applied the result will be as is was designed by original author:

proc getCompanyUser*(httpClient: HttpClient, companyId: string, userId: string): (Option[User], Response) =
  ## Get user of a company

  let response = httpClient.get(basepath & fmt"/companies/{companyId}/users/{userId}")
  constructResult[User](response)

Note: unfortunately Petstore example does not contain any API paths with 2 or more path parameters, otherwise the issue could have been caught before.

Note 2: unfortunately Nim language has no members in Technical Committee

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run
    mvn clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    to update all Petstore samples related to your fix. Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/darklynx/bugfix/nim-client_path-multi-params