Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !8554

[JAVA][native] import the auto generated supporting JSON class only when discriminator is needed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/MosheElisha/master into master 4 years ago
  • Overview 0
  • Commits 20
  • Pipelines 0
  • Changes 167

Created by: MosheElisha

Import the auto generated supporting JSON class only when generateSupportingFiles is true.

Closes #8027 (closed)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Compare
  • master (base)

and
  • latest version
    c0902f90
    20 commits, 2 years ago

167 files
+ 49
- 165

    Preferences

    File browser
    Compare changes
modules/openap‎i-generator/src‎
main/resources/Jav‎a/libraries/native‎
model.m‎ustache‎ +0 -1
pojo.m‎ustache‎ +3 -0
test/java/org/opena‎pitools/codegen/java‎
JavaClientCod‎egenTest.java‎ +32 -0
sam‎ples‎
client/pet‎store/java‎
native-async/src/…‎/…/…/…/client/model‎
AdditionalProper‎tiesAnyType.java‎ +0 -1
AdditionalPrope‎rtiesArray.java‎ +0 -1
AdditionalProper‎tiesBoolean.java‎ +0 -1
AdditionalPrope‎rtiesClass.java‎ +0 -1
AdditionalProper‎tiesInteger.java‎ +0 -1
AdditionalPrope‎rtiesNumber.java‎ +0 -1
AdditionalPrope‎rtiesObject.java‎ +0 -1
AdditionalPrope‎rtiesString.java‎ +0 -1
Anima‎l.java‎ +1 -1
ArrayOfArrayOf‎NumberOnly.java‎ +0 -1
ArrayOfNumb‎erOnly.java‎ +0 -1
ArrayTe‎st.java‎ +0 -1
BigCa‎t.java‎ +1 -1
BigCatAl‎lOf.java‎ +0 -1
Capitaliz‎ation.java‎ +0 -1
Cat.‎java‎ +1 -1
CatAll‎Of.java‎ +0 -1
Catego‎ry.java‎ +0 -1
ClassMo‎del.java‎ +0 -1
Clien‎t.java‎ +0 -1
Dog.‎java‎ +1 -1
DogAll‎Of.java‎ +0 -1
EnumArr‎ays.java‎ +0 -1
EnumCla‎ss.java‎ +0 -1
EnumTe‎st.java‎ +0 -1
FileSchemaTe‎stClass.java‎ +0 -1
FormatT‎est.java‎ +0 -1
HasOnlyRea‎dOnly.java‎ +0 -1
MapTes‎t.java‎ +0 -1
MixedPropertiesAndAdditi‎onalPropertiesClass.java‎ +0 -1
Model200Re‎sponse.java‎ +0 -1
ModelApiRe‎sponse.java‎ +0 -1
ModelRet‎urn.java‎ +0 -1
Name‎.java‎ +0 -1
NumberO‎nly.java‎ +0 -1
Order‎.java‎ +0 -1
OuterComp‎osite.java‎ +0 -1
OuterEn‎um.java‎ +0 -1
Pet.‎java‎ +0 -1
ReadOnlyF‎irst.java‎ +0 -1
SpecialMod‎elName.java‎ +0 -1
Tag.‎java‎ +0 -1
TypeHolderD‎efault.java‎ +0 -1
TypeHolderE‎xample.java‎ +0 -1
User‎.java‎ +0 -1
XmlIte‎m.java‎ +0 -1
native/src/main/…‎/…/…/client/model‎
AdditionalProper‎tiesAnyType.java‎ +0 -1
AdditionalPrope‎rtiesArray.java‎ +0 -1
AdditionalProper‎tiesBoolean.java‎ +0 -1
AdditionalPrope‎rtiesClass.java‎ +0 -1
AdditionalProper‎tiesInteger.java‎ +0 -1
AdditionalPrope‎rtiesNumber.java‎ +0 -1
AdditionalPrope‎rtiesObject.java‎ +0 -1
AdditionalPrope‎rtiesString.java‎ +0 -1
Anima‎l.java‎ +1 -1
ArrayOfArrayOf‎NumberOnly.java‎ +0 -1
ArrayOfNumb‎erOnly.java‎ +0 -1
ArrayTe‎st.java‎ +0 -1
BigCa‎t.java‎ +1 -1
BigCatAl‎lOf.java‎ +0 -1
Capitaliz‎ation.java‎ +0 -1
Cat.‎java‎ +1 -1
CatAll‎Of.java‎ +0 -1
Catego‎ry.java‎ +0 -1
ClassMo‎del.java‎ +0 -1
Clien‎t.java‎ +0 -1
Dog.‎java‎ +1 -1
DogAll‎Of.java‎ +0 -1
EnumArr‎ays.java‎ +0 -1
EnumCla‎ss.java‎ +0 -1
EnumTe‎st.java‎ +0 -1
FileSchemaTe‎stClass.java‎ +0 -1
FormatT‎est.java‎ +0 -1
HasOnlyRea‎dOnly.java‎ +0 -1
MapTes‎t.java‎ +0 -1
MixedPropertiesAndAdditi‎onalPropertiesClass.java‎ +0 -1
Model200Re‎sponse.java‎ +0 -1
ModelApiRe‎sponse.java‎ +0 -1
ModelRet‎urn.java‎ +0 -1
Name‎.java‎ +0 -1
NumberO‎nly.java‎ +0 -1
Order‎.java‎ +0 -1
OuterComp‎osite.java‎ +0 -1
OuterEn‎um.java‎ +0 -1
Pet.‎java‎ +0 -1
ReadOnlyF‎irst.java‎ +0 -1
SpecialMod‎elName.java‎ +0 -1
Tag.‎java‎ +0 -1
TypeHolderD‎efault.java‎ +0 -1
TypeHolderE‎xample.java‎ +0 -1
User‎.java‎ +0 -1
XmlIte‎m.java‎ +0 -1
openapi3/client/…/…‎/…/…/…/…/…/…/…/model‎
AdditionalPrope‎rtiesClass.java‎ +0 -1
Anima‎l.java‎ +1 -1
Apple‎.java‎ +0 -1
AppleR‎eq.java‎ +0 -1
ArrayOfArrayOf‎NumberOnly.java‎ +0 -1
ArrayOfNumb‎erOnly.java‎ +0 -1
ArrayTe‎st.java‎ +0 -1
Banan‎a.java‎ +0 -1
BananaR‎eq.java‎ +0 -1
BasqueP‎ig.java‎ +0 -1
Capitaliz‎ation.java‎ +0 -1
Cat.‎java‎ +1 -1
CatAll‎Of.java‎ +0 -1
Catego‎ry.java‎ +0 -1
ChildC‎at.java‎ +1 -1
ChildCatA‎llOf.java‎ +0 -1
ClassMo‎del.java‎ +0 -1
Clien‎t.java‎ +0 -1
ComplexQuadr‎ilateral.java‎ +0 -1
DanishP‎ig.java‎ +0 -1
Dog.‎java‎ +1 -1
DogAll‎Of.java‎ +0 -1
Drawin‎g.java‎ +0 -1
EnumArr‎ays.java‎ +0 -1
EnumCla‎ss.java‎ +0 -1
EnumTe‎st.java‎ +0 -1
EquilateralT‎riangle.java‎ +0 -1
FileSchemaTe‎stClass.java‎ +0 -1
Foo.‎java‎ +0 -1
FormatT‎est.java‎ +0 -1
Fruit‎.java‎ +0 -1
FruitR‎eq.java‎ +0 -1
GmFrui‎t.java‎ +0 -1
Grandparent‎Animal.java‎ +1 -1
HasOnlyRea‎dOnly.java‎ +0 -1
HealthCheck‎Result.java‎ +0 -1
InlineRespons‎eDefault.java‎ +0 -1
IsoscelesTr‎iangle.java‎ +0 -1
Mamma‎l.java‎ +0 -1
MapTes‎t.java‎ +0 -1
MixedPropertiesAndAdditi‎onalPropertiesClass.java‎ +0 -1
Model200Re‎sponse.java‎ +0 -1
ModelApiRe‎sponse.java‎ +0 -1
ModelRet‎urn.java‎ +0 -1
Name‎.java‎ +0 -1
NullableC‎lass.java‎ +0 -1
NullableS‎hape.java‎ +0 -1
NumberO‎nly.java‎ +0 -1
Order‎.java‎ +0 -1
OuterComp‎osite.java‎ +0 -1
OuterEn‎um.java‎ +0 -1
OuterEnumDefa‎ultValue.java‎ +0 -1
OuterEnumI‎nteger.java‎ +0 -1
OuterEnumInteger‎DefaultValue.java‎ +0 -1
ParentP‎et.java‎ +1 -1
Pet.‎java‎ +0 -1
Pig.‎java‎ +0 -1
Quadrilat‎eral.java‎ +0 -1
Quadrilateral‎Interface.java‎ +0 -1
ReadOnlyF‎irst.java‎ +0 -1
ScaleneTri‎angle.java‎ +0 -1
Shape‎.java‎ +0 -1
ShapeInte‎rface.java‎ +0 -1
ShapeOrN‎ull.java‎ +0 -1
SimpleQuadri‎lateral.java‎ +0 -1
SpecialMod‎elName.java‎ +0 -1
Tag.‎java‎ +0 -1
Triang‎le.java‎ +0 -1
TriangleInt‎erface.java‎ +0 -1
User‎.java‎ +0 -1
Whale‎.java‎ +0 -1
Zebra‎.java‎ +0 -1
modules/openapi-generator/src/main/resources/Java/libraries/native/model.mustache
+ 0
- 1
  • View file @ c0902f90

  • Edit in single-file editor

  • Open in Web IDE


@@ -46,7 +46,6 @@ import javax.validation.Valid;
{{#performBeanValidation}}
import org.hibernate.validator.constraints.*;
{{/performBeanValidation}}
import {{invokerPackage}}.JSON;
{{#models}}
{{#model}}
modules/openapi-generator/src/main/resources/Java/libraries/native/pojo.mustache
+ 3
- 0
  • View file @ c0902f90

  • Edit in single-file editor

  • Open in Web IDE


{{#discriminator}}
import {{invokerPackage}}.JSON;
{{/discriminator}}
/**
* {{#description}}{{.}}{{/description}}{{^description}}{{classname}}{{/description}}
*/{{#description}}
modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java
+ 32
- 0
  • View file @ c0902f90

  • Edit in single-file editor

  • Open in Web IDE


@@ -446,6 +446,38 @@ public class JavaClientCodegenTest {
"import java.net.http.HttpRequest;");
}
@Test
public void testJdkHttpClientWithAndWithoutDiscriminator() throws Exception {
Map<String, Object> properties = new HashMap<>();
properties.put(CodegenConstants.API_PACKAGE, "xyz.abcdef.api");
properties.put(CodegenConstants.MODEL_PACKAGE, "xyz.abcdef.model");
properties.put(CodegenConstants.INVOKER_PACKAGE, "xyz.abcdef.invoker");
File output = Files.createTempDirectory("test").toFile();
output.deleteOnExit();
final CodegenConfigurator configurator = new CodegenConfigurator()
.setGeneratorName("java")
.setLibrary(JavaClientCodegen.NATIVE)
.setAdditionalProperties(properties)
.setInputSpec("src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml")
.setOutputDir(output.getAbsolutePath().replace("\\", "/"));
final ClientOptInput clientOptInput = configurator.toClientOptInput();
DefaultGenerator generator = new DefaultGenerator();
generator.setGeneratorPropertyDefault(CodegenConstants.MODELS, "true");
generator.setGeneratorPropertyDefault(CodegenConstants.APIS, "true");
List<File> files = generator.opts(clientOptInput).generate();
Assert.assertEquals(files.size(), 156);
validateJavaSourceFiles(files);
TestUtils.assertFileContains(Paths.get(output + "/src/main/java/xyz/abcdef/model/Dog.java"),
"import xyz.abcdef.invoker.JSON;");
TestUtils.assertFileNotContains(Paths.get(output + "/src/main/java/xyz/abcdef/model/DogAllOf.java"),
"import xyz.abcdef.invoker.JSON;");
}
@Test
public void testJdkHttpAsyncClient() throws Exception {
Map<String, Object> properties = new HashMap<>();
samples/client/petstore/java/native/src/main/java/org/openapitools/client/model/AdditionalPropertiesAnyType.java
+ 0
- 1
  • View file @ c0902f90

  • Edit in single-file editor

  • Open in Web IDE


@@ -31,7 +31,6 @@ import io.swagger.annotations.ApiModelProperty;
import java.util.HashMap;
import java.util.Map;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
import org.openapitools.client.JSON;
/**
samples/client/petstore/java/native/src/main/java/org/openapitools/client/model/AdditionalPropertiesArray.java
+ 0
- 1
  • View file @ c0902f90

  • Edit in single-file editor

  • Open in Web IDE


@@ -32,7 +32,6 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
import org.openapitools.client.JSON;
/**
0 Assignees
None
Assign to
0 Reviewers
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/MosheElisha/master

Menu

Explore Projects Groups Snippets