Skip to content
GitLab

[OCaml] Fix enum returnType in of_json.mustache for Api Impl

Merged Administrator requested to merge github/fork/syntakker/Fix_OCaml_Enum_ReturnType into master

Created by: syntakker

@cgensoul

Enum return types seem to be incorrectly handled in api implementations *_api.ml for json swagger.txt.

For operations returning enums, processing of return values is rendered as

    Request.read_json_body_as_list_of (JsonSupport.unwrap Push_result.of_yojson) resp body

where PushResult is an enum. It should however render to

    Request.read_json_body_as_list_of (JsonSupport.unwrap Enums.pushresult_of_yojson) resp body

The cause seems to be that neither isEnum nor datatypeWithEnum is available for operations in of_json.mustache:

{{#isEnum}}JsonSupport.unwrap Enums.{{{datatypeWithEnum}}}_of_yojson{{/isEnum}}{{^isEnum}} ...

This fix works for me, however I suppose that a solution could be substantially more elegant if I only was more with conversant CodeGen internals.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
 Commit all changed files. 
 This is important, as CI jobs will verify _all_ generator outputs of your HEAD commit as it would merge with master. 
 These must match the expectations made by your contribution. 
 You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example `./bin/generate-samples.sh bin/configs/java*`. 
 For Windows users, please run the script in [Git BASH](https://gitforwindows.org/).
- [ ] File the PR against the [correct branch](https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches): `master`, `5.1.x`, `6.0.x`
- [ ] If your PR is targeting a particular programming language, @mention the [technical committee](https://github.com/openapitools/openapi-generator/#62---openapi-generator-technical-committee) members, so they are more likely to review the pull request.