Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !8725

[C++][Qt5] Added function to add a new Server. Removed unused variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/basyskom-dege/Qt5AddServer into master Feb 16, 2021
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 10

Created by: basyskom-dege

The issue #8694 (closed) pointed out that there are some unused variables and that it would be handy to be able to add new servers that are not provided in the OpenAPI file. The variables host, port, scheme and basePath have been removed since the servers are handled by the ServerConfiguration class. Furthermore one can add a new ServerConfiguration for an Operation:

[...]
    API api;
    //add a new server with port and server variables
    int newDefaultServerIndex =  api.addServerConfiguration("defaultServer","{server}:{port}","newly added default server", 
        QMap<QString, PFXServerVariable>{ 
        {"server", PFXServerVariable("No description provided","custom-petstore",
        QSet<QString>{ {"custom-petstore"},{"custom-qa-petstore"},{"custom-dev-petstore"} })}, 

        {"port", PFXServerVariable("No description provided","8080",
        QSet<QString>{ {"80"},{"8080"} })},  });

    //using the new servers
    api.setServerIndex("defaultServer",newDefaultServerIndex);
[...]

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

PING @wing328 @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/basyskom-dege/Qt5AddServer