Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !8821

C# Netcore WebRequest and HttpClient functionality

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Blackclaws/csharp-netcore-httpclient-alternative into master Feb 24, 2021
  • Overview 0
  • Commits 32
  • Pipelines 0
  • Changes 283

Created by: Blackclaws

This is WIP work tracking the addition of WebRequest and HttpClient as replacements for RestSharp, as some environments might find it undesirable to include an additional library (Unity, Blazor, etc.).

This is a bit orthogonal to the already open pull request and could be considered a different take on the subject:

https://github.com/OpenAPITools/openapi-generator/pull/8331

It tries to keep as much of the original interface intact as possible. WebRequest more so than HttpClient which simply does not offer many of the customizations that WebRequest and RestSharp do.

You can try it out by setting the library to httpclient by cliswitch or adding:

library: httpclient

to the global config in the config file you're using. Should hopefully alleviate/fix #6800 (closed) and #853 (closed)

If you also want to get rid of the dependency on Polly add

additionalProperties: supportsRetry: false

aswell

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

 @mandrean @frankyjuang @shibayan

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Blackclaws/csharp-netcore-httpclient-alternative