Skip to content
GitLab

[csharp-netcore] Fix handling of Dictionary query parameters and fix deepObject style parameter handling

Merged Administrator requested to merge github/fork/Blackclaws/csharp-deepObject-fix into master

Created by: Blackclaws

This was triggered by this issue which it should close https://github.com/OpenAPITools/openapi-generator/issues/8798

Looking into the issue I found that indeed SwaggerUI and the csharp-netcore client libraries were generating different queries. Neither of which was getting read by the newly updated aspnetcore generator (https://github.com/OpenAPITools/openapi-generator/pull/8826). It appears that neither format was acceptable there and this is also something Swashbuckle needs to fix (https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2034) as their generated spec does not actually work with the controller its supposed to query.

This pull request does two things:

  • Fix default handling so that it corresponds to what SwaggerUI is doing for Dictionaries
  • Fix deepObject handling so that it works for required parameters as well
  • Fix deepObject handling for Dictionary style inline objects with no properties defined (this might not be completely to spec, but it makes sense to do so, see also: https://swagger.io/docs/specification/serialization/,
  • Fix NullPointerException caused by the DefaultCodegen not finding a Schema

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Closes https://github.com/OpenAPITools/openapi-generator/issues/8798