Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !8960

[C++][Qt]Replace usage of QVariant with a more intuitive optional wrapper

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/etherealjoy/use_optional_wrapper_instead_of_qvariant into master Mar 12, 2021
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 11

Created by: etherealjoy

Fixes #8934 (closed)

Issue was due to Optional support with QVariant here #8733

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Changes

  • QVariant cannot construct user types hence it is not suitable for all cases
  • A more intuitive approach is provided, which also shows the type of optional in the api instead of plain QVariant
  • Added handling of optional body

Function declaration now looks like this

void deletePet(const qint64 &pet_id, const OptionalParam<QString> &api_key = OptionalParam<QString>());
void updatePetWithForm(const qint64 &pet_id, const OptionalParam<QString> &name = OptionalParam<QString>(), 
           const OptionalParam<QString> &status = OptionalParam<QString>());

instead of this

void deletePet(const qint64 &pet_id, const QVariant &api_key = QVariant());
void updatePetWithForm(const qint64 &pet_id, const QVariant &name = QVariant(), const QVariant &status = QVariant());

User types are supported like this

    QList<OAIObject> list;
    QMap<QString, OAIObject> map;
    QList<QString> strl;
    list.append(OAIObject());
    api->notifyTopicV1(list);
    api->notifyTopicV1();
    api->notifyTopicV2();
    api->notifyTopicV2(map);
    api->notifyTopicV3();
    api->notifyTopicV3(strl);

cc @ravinikam @stkrwork @MartinDelille @muttleyxd

@xconverge I had to rework this due to side effects, made a more simpler and intuitive approach.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/etherealjoy/use_optional_wrapper_instead_of_qvariant