Skip to content
GitLab

[Slim] Add PHP CodeSniffer to check coding style

Merged Administrator requested to merge github/fork/ybelenko/slim_psr2 into master

Created by: ybelenko

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

As defined in guide of contributing, PHP templates should meet PSR-2 coding style.

I've added PHP CodeSniffer package to check source code on violations against user defined standard. User can change coding standard with phpcsStandard config option. 'PSR12' is default(checks against PSR-1 and PSR-2)

I think it's perfect time to add linters and code formatters while generator is small like Slim now. It will be easier to update templates and check them automatically every next PR. By this reason I suggest to merge this PR before #735.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh