Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9033

Sets model.additionalProperties for composed schemas

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/spacether/set_model_additionalProperties_for_composed_schema into master Mar 21, 2021
  • Overview 0
  • Commits 6
  • Pipelines 0
  • Changes 3

Created by: spacether

Sets model.additionalProperties for composed schemas This allows v2 spec additionalProperties values to default to {} (AnyType schema) when omitted No generator uses this data yet.

Tests updated for v2 and v3 additionalProperties checking v2 specs, legacy behavior (disallowAdditionalPropertiesIfNotPresent = True, supportsAdditionalPropertiesWithComposedSchema = False)

  • additionalProperties unset/false/true -> model.additionalProperties = null
  • additionalProperties schema -> model.additionalProperties = schema

v2 specs, new behavior (disallowAdditionalPropertiesIfNotPresent = False, supportsAdditionalPropertiesWithComposedSchema=True)

  • additionalProperties unset/false/true -> model.additionalProperties = {} AnyType schema
  • additionalProperties schema -> model.additionalProperties = schema

This update will be used in the python generator in https://github.com/OpenAPITools/openapi-generator/pull/8802

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/spacether/set_model_additionalProperties_for_composed_schema