An error occurred while fetching the assigned milestone of the selected merge_request.
[csharp][netcore-httpclient] Reuse HttpClient, Allow use of external HttpClient, Fix Socket Exhaustion
-
Review changes -
-
Download -
Email patches
-
Plain diff
Closed
Administrator requested to merge github/fork/Blackclaws/csharp-netcore-httpclient-dispose into master
Created by: Blackclaws
Fixed an existing issue that made the HttpClient open new sockets for each connection even if being reused as the UserAgent was being set on the Client and not the request. Also makes HttpClient settable from external. Fixes: https://github.com/OpenAPITools/openapi-generator/issues/9060
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)
Compare and