Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9145

[csharp][netcore-httpclient] Refactor of constructors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/lucamazzanti/master into master Mar 31, 2021
  • Overview 0
  • Commits 6
  • Pipelines 0
  • Changes 10

Created by: lucamazzanti

It tries to reduce the number of constructors introduced in previous PR. Related to: #9060 (closed), #9085

Refactor on constructors

In the previous PM I created too much constructors. This is an emprovement to reduce them:

  1. I kept the HttpClient service as first parameter when available in signature
  2. Then the configurations
  3. Then the optional HttpClientHandler

With this PM we have in ApliClient:

  1. ctor()
  2. ctor(string basePath)
  3. ctor(HttpClient client, HttpClientHandler handler = null)
  4. ctor(HttpClient client, string basePath, HttpClientHandler handler = null)

(point 1-2 marked as obsolete) and in ApiClass:

  1. ctor()
  2. ctor(string basePath)
  3. ctor(Configuration configuration)
  4. ctor(HttpClient client, HttpClientHandler handler = null)
  5. ctor(HttpClient client, string basePath, HttpClientHandler handler = null)
  6. ctor(HttpClient client, Configuration configuration, HttpClientHandler handler = null)
  7. ctor(ISynchronousClient client, IAsynchronousClient asyncClient, IReadableConfiguration configuration)

(point 1-3 marked as obsolete)

Obsolete constructors

Marked constructors without the explicit HttpClient parameter as obsolete.

Spaces and indentations

Unfortunatly I had a different setup for spaces and indentations on my IDE and I did not see it on my local versioning tool. So the changes have some spaces because I fixed my previous PM, moving some tabs to 4 spaces. They are a few lines not so much, but this is why you see some noise in the diffs, its a fix to keep and I will avoid it at all in the future.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/lucamazzanti/master