Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9167

[dart] Improve types & imports

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter Leibiger requested to merge github/fork/kuhnroyal/dart/types into master Apr 04, 2021
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 79
  • don't use importMapping as it is intended for something different that is not possible in dart
  • introduce imports map for dart specific features
  • always import dart:core
  • get rid of additionalReservedWords
  • fix --type-mappings not working
  • use required type mappings in samples
  • no longer define additional reserved words as it is impossible to list all anyways, they can now be configured via type-mapping parameter
  • improve dart-dio imports

Fixes #9029 (closed)

I think this is a much better solution and allows customization via CLI or config parameters. importMapping is meant to be used to map a class/type to that of a specific package, like List: java.util.List this is not possible in Dart. importMapping is being used internally in several places and if it is miss-used in the Dart generator as it was until now, it break the possibility of specifying typeMappings via CLI/config.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kuhnroyal/dart/types