Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9171
An error occurred while fetching the assigned milestone of the selected merge_request.

[Go][server] parse bool in query parameter

  • Review changes

  • Download
  • Email patches
  • Plain diff
William Cheng requested to merge cherrypick-7724 into master 4 years ago
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 6

this PR allow support to boolean values in query parameters. I change the petstore api example to generate a test case

The commits are pretty self explainatory, i added a function alongside parseInt32Parameter, and update the template in case of boolean value.

Cherrypick #7724

Credits: @Gmtstephane

Boolean query parameter tests passed via https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/10093/workflows/7241f115-ac1f-4b3c-b1be-920d5ac6ab7f/jobs/23706/parallel-runs/2?filterBy=ALL (node 0,1)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)

Loading
Loading

Activity


  • William Cheng changed title from Cherrypick 7724 to Go-server parse bool in query parameter 4 years ago

    changed title from Cherrypick 7724 to Go-server parse bool in query parameter

  • William Cheng mentioned in merge request !7724 (closed) 4 years ago

    mentioned in merge request !7724 (closed)

  • William Cheng added Issue: Bug Server: Go labels 4 years ago

    added Issue: Bug Server: Go labels

  • William Cheng changed milestone to %5.1.1 4 years ago

    changed milestone to %5.1.1

  • William Cheng changed title from Go-server parse bool in query parameter to [Go][server] parse bool in query parameter 4 years ago

    changed title from Go-server parse bool in query parameter to [Go][server] parse bool in query parameter

  • William Cheng closed 4 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference:
Source branch: cherrypick-7724

Menu

Explore Projects Groups Snippets