Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9453

Fix Gradle Plugin ValidateTask not working under Gradle 7.0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rm3l/fix/9328_validatetask_gradle_7 into master May 11, 2021
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: rm3l

This fixes #9328 (closed), which prevents from using the OpenAPI Generator Gradle Plugin with the latest Gradle 7.0.

As of Gradle 7.0, an error is returned at configuration time if a plugin task declares a property of "mutable" type with a setter. See https://docs.gradle.org/7.0/userguide/validation_problems.html#mutable_type_with_setter for further details.

This PR fixes this issue by declaring such properties as Kotlin val members instead, so they do not have setters. To validate that the fix works, this PR also adds the capability to run the same set of tests in ValidateTaskDslTest using different instances of GradleRunner, configured with different versions of Gradle.

@agilob and @jimschubert I'm mentioning the two of you since you reviewed a similar PR (#9059 ) about GenerateTask.

cc @ilya40umov @wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rm3l/fix/9328_validatetask_gradle_7