Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9469

Add support for Boolean in R client generator

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/sneumann/fix/issue9468 into master May 12, 2021
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 7

Created by: sneumann

Hi @Ramanth @saigiridhar21 et al,

as mentioned in the branch name, this PR is in response to (my) #9468 . Unfortunately I am not a openapi-generator hacker, so I have no idea if this is what's required, and its a best-effort approach. What I did:

  1. extend the model.mustache in two places to check for the correct class, and I did that in analogy to the lines before/after my insertion
  2. extend the model.mustache in two places further down, where numbers are printed with %d% and everything else was printed as "%s". The latter needed changing. I HOPE what I did results in unchanged "%s" for everything but Boolean, and %s for booleans
  3. finally the logical values are needed in lowercase, so I surrounded self${{baseName}}bytolower()` in case of booleans.

The second commit adds the petstore, changed only where the logical complete is involved. And apparently my editor removed an empty line at the end of the template, so some changes remove only whitespace I do not know exactly how else I can test everything. Hope that helped nevertheless, Yours, Steffen

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sneumann/fix/issue9468