Skip to content
GitLab

[java][native] Remove JAX-RS dependency from generated java-native client.

Merged Administrator requested to merge github/fork/shartte/fix-jax-rs into master

Created by: shartte

This removes the dependency on JAX-RS from the Java native client template by making the following changes:

  1. Remove use of GenericType This was originally introduced in #7263 by presumably copy pasting a piece of code for OneOf/AnyOf support from the Jersey client. It was using GenericType from JAX-RS, which seems unnecessary since it doesn't seem to generate generic type instantiations (the anyOf/oneOf deserializer will also use {{.}}.class, and not GenericType or similar type tokens).

  2. Remove ContextResolver implementation The JSON class implements the JAX-RS ContextResolver interface, which seems unnecessary for a native Java client in a non JAX-RS environment (probably copy paste)

  3. Removed the respective dependencies from build.gradle/pom.xml.

  4. [OPTIONAL] Set source encoding to UTF-8 in build.gradle I had to set the source encoding in the build.gradle template, as the samples were not even building for me otherwise. The pet store API spec seems to contain UTF-8 characters which are copied into the source, breaking the build with windows default encoding for me. (This should probably be split into a separate PR; but I was unable to build and validate the sample without this fix).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)