Created by: tmeneau
Fixes #9683 by ensuring Kotlin model names are generated by escaping sanitized characters rather than describing them. This is essentially the same change as introduced in https://github.com/OpenAPITools/openapi-generator/pull/7598 for variable names, but for model names. The fix works by calling the more generic sanitizeNames before calling the language-specific sanitize method; prior to this comment only the period (".") character and some kotlin-specific characters were being escaped.
note: the steps to update the samples did not result in changes to any committed files.
Breaking Change Warning
Note that this could be considered a breaking change, since it changes the way model names and file names are generated. This is especially true given a couple different tests validated the pre-existing behavior.
Technical Committee Mentions
- @jimschubert
- @dr4ke616
- @karismann
- @Zomzog
- @andrewemery
- @4brunu
- @yutaka0m
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.