Created by: josh-bridge
The previous check of isReadOnly was not applicable to whether a value should be null or not. As far as I can tell that is more to do with a RESTful design principal than to do with whether the code should present a models values as nullable.
Initially I thought the ? should be removed if the value is set to required = true but it is important to note that required != non-null, i.e. the field can be required but the value might still be null (if nullable = true).
The default null value will no longer be supplied if the value is not nullable.
Also removed escaping of default string values (this would cause any default string value to be written to the file as
val test = "value" instead of val test = "value".
This would clearly be a breaking change so have set it to a major release branch. Please let me know if you think it could actually go into a minor release.
[kotlin committee] @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.