Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !984

[Swift4] Use CodeableHelper's dateformatter in encode() if configured

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/moovetech/swift4_codeablehelper_encode_dateformatter into master 6 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: manhhavu

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update Swift4's CodeableHelper to use configured dateformatter in encode() method, the same as its decode().

Opened issue: #982 (closed)

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

Compare
  • master (base)

and
  • latest version
    770eaa18
    1 commit, 2 years ago

5 files
+ 25
- 17

    Preferences

    File browser
    Compare changes
modules/openapi-gen‎erator/…/…/…/swift4‎
CodableHelp‎er.mustache‎ +11 -7
samples‎/client‎
petstore-secur‎ity-test/swift‎
.openapi-‎generator‎
VER‎SION‎ +1 -1
git_p‎ush.sh‎ +1 -1
petstore/sw‎ift4/default‎
.openapi-‎generator‎
VER‎SION‎ +1 -1
PetstoreClient/‎Classes/OpenAPIs‎
CodableHe‎lper.swift‎ +11 -7
modules/openapi-generator/src/main/resources/swift4/CodableHelper.mustache
+ 11
- 7
  • View file @ 770eaa18

  • Edit in single-file editor

  • Open in Web IDE


@@ -47,13 +47,17 @@ open class CodableHelper {
if prettyPrint {
encoder.outputFormatting = .prettyPrinted
}
encoder.dataEncodingStrategy = .base64
let formatter = DateFormatter()
formatter.calendar = Calendar(identifier: .iso8601)
formatter.locale = Locale(identifier: "en_US_POSIX")
formatter.timeZone = TimeZone(secondsFromGMT: 0)
formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSSXXXXX"
encoder.dateEncodingStrategy = .formatted(formatter)
if let df = self.dateformatter {
encoder.dateEncodingStrategy = .formatted(df)
} else {
encoder.dataEncodingStrategy = .base64
let formatter = DateFormatter()
formatter.calendar = Calendar(identifier: .iso8601)
formatter.locale = Locale(identifier: "en_US_POSIX")
formatter.timeZone = TimeZone(secondsFromGMT: 0)
formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSSXXXXX"
encoder.dateEncodingStrategy = .formatted(formatter)
}
do {
returnedData = try encoder.encode(value)
samples/client/petstore/swift4/default/.openapi-generator/VERSION
+ 1
- 1
  • View file @ 770eaa18

  • Edit in single-file editor

  • Open in Web IDE

3.2.3-SNAPSHOT
\ No newline at end of file
3.3.0-SNAPSHOT
\ No newline at end of file
samples/client/petstore/swift4/default/PetstoreClient/Classes/OpenAPIs/CodableHelper.swift
+ 11
- 7
  • View file @ 770eaa18

  • Edit in single-file editor

  • Open in Web IDE


@@ -47,13 +47,17 @@ open class CodableHelper {
if prettyPrint {
encoder.outputFormatting = .prettyPrinted
}
encoder.dataEncodingStrategy = .base64
let formatter = DateFormatter()
formatter.calendar = Calendar(identifier: .iso8601)
formatter.locale = Locale(identifier: "en_US_POSIX")
formatter.timeZone = TimeZone(secondsFromGMT: 0)
formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSSXXXXX"
encoder.dateEncodingStrategy = .formatted(formatter)
if let df = self.dateformatter {
encoder.dateEncodingStrategy = .formatted(df)
} else {
encoder.dataEncodingStrategy = .base64
let formatter = DateFormatter()
formatter.calendar = Calendar(identifier: .iso8601)
formatter.locale = Locale(identifier: "en_US_POSIX")
formatter.timeZone = TimeZone(secondsFromGMT: 0)
formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSSXXXXX"
encoder.dateEncodingStrategy = .formatted(formatter)
}
do {
returnedData = try encoder.encode(value)
samples/client/petstore-security-test/swift/.openapi-generator/VERSION
+ 1
- 1
  • View file @ 770eaa18

  • Edit in single-file editor

  • Open in Web IDE

3.0.0-SNAPSHOT
\ No newline at end of file
3.3.0-SNAPSHOT
\ No newline at end of file
samples/client/petstore-security-test/swift/git_push.sh
+ 1
- 1
  • View file @ 770eaa18

  • Edit in single-file editor

  • Open in Web IDE


#!/bin/sh
# ref: https://help.github.com/articles/adding-an-existing-project-to-github-using-the-command-line/
#
# Usage example: /bin/sh ./git_push.sh wing328 swagger-petstore-perl "minor update"
# Usage example: /bin/sh ./git_push.sh wing328 openapi-pestore-perl "minor update"
git_user_id=$1
git_repo_id=$2
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!10217
Source branch: github/fork/moovetech/swift4_codeablehelper_encode_dateformatter

Menu

Explore Projects Groups Snippets