Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !9859

[cleanup] erefactor/AutoRefactor - Log parameters rather than log message

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/cal101/erefactor/master/1/arf/LogParametersRatherThanLogMessageCleanUp into master Jun 29, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 11

Created by: cal101

@OpenAPITools/generator-core-team

Please note that the changes are technically as correct as the code was before but that for example the log message in RustServerCodegen.java and other files is (and was) printing wrong or incomplete information. I don't have the time to fix this but the PR may be useful nevertheless. Please note that this is the last PR that addresses LogParametersRatherThanLogMessage. All log calls erefactor found are done with this PR.

I saw that a lot of test asserttions have wrong argument order. I plan to provide PRs for that when I find some time.

Best regards, Cal

AutoRefactor cleanup 'LogParametersRatherThanLogMessage' applied by erefactor:

Replaces a string concatenation as parameter of a logger method by a string template followed by objects.

For AutoRefactor see https://github.com/JnRouvignac/AutoRefactor For erefactor see https://github.com/cal101/erefactor

Dear Project Team!

This pull request is provided in the hope that it will be useful.

Changes are manually reviewed after they passed the test suite of your project. Only successful reviews become project PRs. Errors found are reported upstream to support the cleanup providers.

But please do a careful review of your own as usual because tools have bugs and bugs in the changes may have been overlooked.

For scalability and out of fun and laziness, the creation of commits and PRs and parts of the change handling are automated.

If you are not interested or want to discuss issues just comment the PR as usual.

Have fun, Cal

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/cal101/erefactor/master/1/arf/LogParametersRatherThanLogMessageCleanUp