Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1062

Propagate stack traces from child processes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Genius/master into master Sep 25, 2018
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: nightpool

This is a followup to #894 that fixes #985 (closed) (prematurely closed because the reporter fixed the issue on a fork).

the rationale here:

the subprocess will always bubble up a JSON-serialized representation of an Error object, and we use err.message to maintain the same behavior from #894. Because we have no way of knowing what specific type this error was or even guarantee that we'd have access to that constructor (it may be a library or function that lives only in the child process), we need to create a normal Error object. However, we can use the properties that are bubbled up, including stack, message, code, etc, so we Object.assign them.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Genius/master