Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1114

Fix typo in forcedReconnection variable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/marcbachmann/patch-2 into master Nov 06, 2018
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: marcbachmann

Just another tiny typo I saw when I was reading through the code.

I went through the code because I was wondering why there was a default fallback in the example about how to reuse redis connections: https://github.com/OptimalBits/bull/blob/master/PATTERNS.md#reusing-redis-connections

What is bclient exactly and can I reuse the existing connection for that? To me it looks like it's some kind of connection to do separate requests outside of the regular job processing flow, so that they won't interfere.

  const queueSettings = {
    createClient (type) {
      if (type === 'client' || type === 'bclient') return redisForMutations
      if (type === 'subscriber') return redisForSubscriptions
      throw new Error(`Requested unknown redis client instance for type '${type}'`)
    },
    settings: {retryProcessDelay: 10000}
  }

I could create a new issue or PR to improve the documentation.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/marcbachmann/patch-2