Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1167

Fix takeLock method & extracted methods

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged rysi3k requested to merge github/fork/rysi3k/extracted_methods into develop Jan 07, 2019
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 3

Hello, simple PR for two things:

  • fix lockKey field usage - prevously lockKey was field (used in tests) and method, now left only method
  • extracted processOnNextTick method, for simplicty and better possibility to override in custom cases

In my project i need to stop processing job in custom case, so I can override processOnNextTick to do this. Same thing with isQueueClosing(). Changes do not affect logic, so could not cause problems.

Regards

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rysi3k/extracted_methods