Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1206

consider priority when promoting a job #1205

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/sokki/fix/promote-with-prio into develop Feb 04, 2019
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: sokki

job.promote() just LPUSHed to the waiting queue. That meant that all 'new' jobs with any priority were processed first.

Additionally, the waiting event was not emitted. I'm not sure if this was on purpose. I found it confusing.

fixes https://github.com/OptimalBits/bull/issues/1205

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sokki/fix/promote-with-prio