Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1294

Rewrite timing logic for updating delay set

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/peakon/fix/delay_timer into develop Apr 23, 2019
  • Overview 15
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: holm

This rewrites the logic around updating delay set to be a bit safer and simpler (imo).

In the previous code there was a race-condition due to the timer being cleared before the call to process the delay set, and in the time until the processing was done, another processing could have been started.

The new code does away with the guardian timer, and instead combines the guardian timer with the updates coming from new jobs being posted.

Refs https://github.com/OptimalBits/bull/issues/1222

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/peakon/fix/delay_timer