Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1720

feat: pass clientName to createClient function

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tebriel/createClient-clientName into develop May 05, 2020
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: tebriel

Overrides the options.redis settings for clientName for creating a new client

When specifying createClient as part of the Bull.QueueOptions there is no way to know the Queue's name (from queue.clientName).

When calling queue.process, this.setHandler is invoked which calls setWorkerName however this only does so on the client, and not on the eclient (subscriber) nor on the bclient.

I opted to hand the clientName via connectionName in the redis options (overriding the defaults passed in to the QueueOptions to allow the createClient function to determine what to do with these options.

Additionally I slightly tweaked the example to note that this value is present and to better showcase how to use the createClient function.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tebriel/createClient-clientName