Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !1796

Throw an error if concurrency value is invalid

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/theoephraim/develop into develop Jul 09, 2020
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: theoephraim

Had a configuration error on my side and was passing through "123," as a concurrency setting for a queue. This caused concurrency-- to be NaN which stopped the queue from processing any jobs. So I've added a quick check to throw an error.

Also in the process while trying to get things running, I was having problems because spread syntax is not supported under node v8.3 - which was making the linter complain.

I also tried to add a test, but there wasn't really an obvious spot to do it. Generally more docs around getting the code up and running and contributing would be helpful.

Cheers and thanks for writing and maintaining this package!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/theoephraim/develop