Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !229

Fixed #228

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/yonivy/master into master Jan 11, 2016
  • Overview 6
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: yonivy

The priorities did not worked correctly.

  1. The strategy function received the wrong index so the number of jobs to process did the opposite of what it needs to do (0 for 'critical', 1 for 'high' etc.).
  2. Reversing the queues array messed a lot. Array.prototype.reverse() is done in place so we're reversing it on each call, not to mention the other possible side effects that may happen from mutating the original array (didn't test other stuff, but it seems like a bug waiting to happen).

Note The second commit is just to fix some indentation mishaps. I'm working with emacs but I switched to sublime text and installed EditorConfig to prevent any harm.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/yonivy/master